From 0b600102769fe066c2aec7046c970009dbd5ef5f Mon Sep 17 00:00:00 2001
From: Ollie Chick <olliechick@gmail.com>
Date: Fri, 2 Jul 2021 14:51:47 +1200
Subject: [PATCH] fix(job-details): encodeURI of job ID for URL

fixes #416
---
 src/server/views/partials/dashboard/jobDetails.hbs | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/server/views/partials/dashboard/jobDetails.hbs b/src/server/views/partials/dashboard/jobDetails.hbs
index 67bd7491..ae05ac33 100644
--- a/src/server/views/partials/dashboard/jobDetails.hbs
+++ b/src/server/views/partials/dashboard/jobDetails.hbs
@@ -68,9 +68,9 @@
 <div class="row">
   <div class="col-sm-4">
     <h5>Permalinks</h5>
-    <a href="{{ basePath }}/{{ encodeURI queueHost }}/{{ encodeURI queueName }}/{{ this.id }}" class="btn btn-info">Job
+    <a href="{{ basePath }}/{{ encodeURI queueHost }}/{{ encodeURI queueName }}/{{ encodeURI this.id }}" class="btn btn-info">Job
       {{ this.id }}</a>
-    <a href="{{ basePath }}/{{ encodeURI queueHost }}/{{ encodeURI queueName }}/{{ this.id }}?json=true"
+    <a href="{{ basePath }}/{{ encodeURI queueHost }}/{{ encodeURI queueName }}/{{ encodeURI this.id }}?json=true"
       class="btn btn-info">JSON</a>
   </div>
 </div>
@@ -148,7 +148,7 @@
     <nav aria-label="Unprocessed navigation">
       <ul class="pagination">
         <li><a
-            href="{{ basePath }}/{{ encodeURI queueHost }}/{{ encodeURI queueName }}/{{ this.id }}?unprocessedCursor={{ this.unprocessedCursor }}&amp;unprocessedCount={{ this.unprocessedCount }}"
+            href="{{ basePath }}/{{ encodeURI queueHost }}/{{ encodeURI queueName }}/{{ encodeURI this.id }}?unprocessedCursor={{ this.unprocessedCursor }}&amp;unprocessedCount={{ this.unprocessedCount }}"
             aria-label="Previous">
             <span aria-hidden="true">&raquo;</span>
           </a>
@@ -157,7 +157,7 @@
     </nav>
 
     {{#each this.unprocessedChildren}}
-    <a href="{{ ../basePath }}/{{ encodeURI ../queueHost }}/{{ encodeURI this.queueName }}/{{ this.id }}">
+    <a href="{{ ../basePath }}/{{ encodeURI ../queueHost }}/{{ encodeURI this.queueName }}/{{ encodeURI this.id }}">
       <span class="label label-danger">{{ this.id }}</span>
     </a>
     {{/each}}
@@ -173,7 +173,7 @@
     <nav aria-label="Processed navigation">
       <ul class="pagination">
         <li><a
-            href="{{ basePath }}/{{ encodeURI queueHost }}/{{ encodeURI queueName }}/{{ this.id }}?processedCursor={{ this.processedCursor }}&amp;processedCount={{ this.processedCount }}"
+            href="{{ basePath }}/{{ encodeURI queueHost }}/{{ encodeURI queueName }}/{{ encodeURI this.id }}?processedCursor={{ this.processedCursor }}&amp;processedCount={{ this.processedCount }}"
             aria-label="Previous">
             <span aria-hidden="true">&raquo;</span>
           </a>
@@ -182,7 +182,7 @@
     </nav>
 
     {{#each this.processedChildren}}
-    <a href="{{ ../basePath }}/{{ encodeURI ../queueHost }}/{{ encodeURI this.queueName }}/{{ this.id }}">
+    <a href="{{ ../basePath }}/{{ encodeURI ../queueHost }}/{{ encodeURI this.queueName }}/{{ encodeURI this.id }}">
       <span class="label label-success">{{ this.id }}</span>
     </a>
     {{/each}}