Remove json dependency. JSONAPI.parse now only accepts a hash. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2016
NullVoxPopuli
force-pushed
the
bugfix/raise-correct-exception-on-nil-input
branch
from
f8a24d9 to
f733239
Compare
|
rebased |
beauby
reviewed
Sep 28, 2016
| @@ -23,6 +23,7 @@ module JSONAPI | |||
| # objects in the primary data must have an id. | |||
| # @return [JSONAPI::Parser::Document] | |||
| def parse(document, options = {}) | |||
| raise Parser::InvalidDocument, 'document cannot be nil' if document.nil? | |||
There was a problem hiding this comment.
I'm thinking that we might as well go the extra mile and require document to be a Hash.
| @@ -94,4 +94,10 @@ | |||
| expect(document.data.first.relationships.author.data.to_hash).to eq @author_data_hash | |||
| expect(document.data.first.relationships.comments.data.map(&:to_hash)).to eq @comments_data_hash | |||
| end | |||
|
|
|||
| it 'raises InvalidDocument on nil input' do | |||
beauby
requested changes
Sep 28, 2016
|
It also made the json.parse method not required, so I removed that, too |
beauby
reviewed
Sep 28, 2016
|
|
||
| Parser::Document.new(hash, options) | ||
| raise Parser::InvalidDocument, 'document must be a hash' unless document.is_a?(Hash) | ||
| Parser::Document.new(document, options) |
There was a problem hiding this comment.
Right, then you can also remove the dependency to json in both this file and the gemspec.
beauby
changed the title
|
woo! |
|
Which part needs to be updated? |
beauby
approved these changes
Sep 30, 2016
|
My bad, no update needed. LGTM, rebase and we can merge. |
NullVoxPopuli
force-pushed
the
bugfix/raise-correct-exception-on-nil-input
branch
from
42ba2c9 to
01e5ff8
Compare
|
rebased |
NullVoxPopuli
deleted the
bugfix/raise-correct-exception-on-nil-input
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseds #40, fixes #33, #35.