nil check + test

beauby · Sep 27, 2016 · f733239 · f733239
1 parent 0b9ef9c
commit f733239
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/parser/lib/jsonapi/parser.rb b/parser/lib/jsonapi/parser.rb
@@ -23,6 +23,7 @@ module JSONAPI
   #     objects in the primary data must have an id.
   # @return [JSONAPI::Parser::Document]
   def parse(document, options = {})
+    raise Parser::InvalidDocument, 'document cannot be nil' if document.nil?
     hash = document.is_a?(Hash) ? document : JSON.parse(document)
 
     Parser::Document.new(hash, options)

diff --git a/parser/spec/parser_spec.rb b/parser/spec/parser_spec.rb
@@ -94,4 +94,10 @@
     expect(document.data.first.relationships.author.data.to_hash).to eq @author_data_hash
     expect(document.data.first.relationships.comments.data.map(&:to_hash)).to eq @comments_data_hash
   end
+
+  it 'raises InvalidDocument on nil input' do
+    expect {
+      JSONAPI.parse(nil)
+    }.to raise_error JSONAPI::Parser::InvalidDocument
+  end
 end