Support for typing.Sequence[int]

[ivantitov-zd]

@dispatch
async def get_updates(version: Sequence[int]) -> List[Update]:

For the code above I got
NotImplementedError: There is currently no support for "typing.Sequence[int]". Please open an issue at https://github.com/wesselb/plum/issues

[wesselb]

Hey @anvdev, just letting you know that I've seen this and that I'm working on this.

[wesselb]

Hey @anvdev,

The latest release, v1.5.4, adds support for typing.Iterable and typing.Sequence:

from typing import Sequence

from plum import dispatch

@dispatch
def el_to_str(x: Sequence[int]) -> Sequence[str]:
    for i in range(len(x)):
        x[i] = str(x[i])
    return x

>>> el_to_str([1, 2, 3])
['1', '2', '3']

>>> el_to_str([1.0, 2, 3])
For function "el_to_str", signature Signature(List[Union[builtins.int, builtins.float]]) could not be resolved.

[ivantitov-zd]

Thanks for your work.

[ilan-gold]

I must be missing something but the following raises an AmbiguousLookupError

from collections.abc import Iterable
import plum

@plum.dispatch
def f(x: Iterable[int]): print("int!")

@plum.dispatch
def f(x: Iterable[str]): print("str!")

f(['first', 'second']) # AmbiguousLookupError: `f(['first', 'second'])` is ambiguous.

If not, happy to contribute a fix. Is there no support for checking Iterable and only list/tuple?

[PhilipVinc]

It's possibly a bug. Can you open a separate issue?

[ilan-gold]

Yes.