Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace inspect.signature with beartype._util.func.arg.utilfuncargiter.iter_func_args #121

Open
wesselb opened this issue Oct 13, 2023 · 3 comments

Comments

@wesselb
Copy link
Member

wesselb commented Oct 13, 2023

What the title says, for the sake of speed!

The one missing feature is that inspect.signature gives the return type too, whereas iter_func_args just loops over the arguments, so that's the only wrinkle that would need to be ironed out.

@PhilipVinc
Copy link
Collaborator

If you merge my part2 PR, this is partly solved because I split the signature inspection from the return type inspection!

@PhilipVinc
Copy link
Collaborator

Can be*

@wesselb
Copy link
Member Author

wesselb commented Oct 13, 2023

@PhilipVinc I'm going over your PR as we speak! Planning to leave a review before the end of the night. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants