Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do flow control on incoming streams #156

Open
fasterthanlime opened this issue Mar 31, 2024 · 0 comments
Open

Do flow control on incoming streams #156

fasterthanlime opened this issue Mar 31, 2024 · 0 comments

Comments

@fasterthanlime
Copy link
Collaborator

Not exactly sure how it should work yet (ie. when and how much capacity to give back to the peer).

Ideally we shouldn't wait until it reaches zero, especially if we've already processed what they've sent us. It depends how fast it's processed by the user on our side I suppose?

We should also reset the stream if we don't care about the request body (acting as a server).


The reason this is on top of mind is because StreamIncoming::capacity is unused right now, and rustc is unhappy about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant