Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attaching file to transaction on mobile. #979

Open
jahagirdar opened this issue Oct 4, 2019 · 4 comments · May be fixed by #1869
Open

Attaching file to transaction on mobile. #979

jahagirdar opened this issue Oct 4, 2019 · 4 comments · May be fixed by #1869
Labels
enhancement help wanted platform:mobile Issues related to using Fava on mobile devices

Comments

@jahagirdar
Copy link

Hi,
The current document upload implementation depends on dropping a file on a journal entry to attach it. I am not sure how to do it on a mobile platform. If anyone has some success with it please guide.

@yagebu yagebu added enhancement platform:mobile Issues related to using Fava on mobile devices labels Oct 8, 2019
@yagebu yagebu changed the title Android, attaching file to transaction. Attaching file to transaction on mobile. Oct 8, 2019
@yagebu
Copy link
Member

yagebu commented Oct 8, 2019

As far I can tell, it's just not possible with drag and drop on mobile. So an alternative implementation would be required - a PR would be welcome.

@jahagirdar
Copy link
Author

I can take a stab at creating the required PR.
Is there a hacking guide for the project?
Is the framework vanilla flask or are there other standard components used here?
Should we baseline the View on bootstrap? or is the team looking at other layout framework?

@yagebu
Copy link
Member

yagebu commented Nov 3, 2019

@jahagirdar: Thank you for being interested in submitting a PR. There's no hacking guide for the project except for the small amount of information on the Development page on the website. For the backend, Flask is used, in the frontend it's a mix of plain HTML and CSS with some vanilla Javascript and Svelte for the more interactive UI components.

I guess the "uploading document" button or so could be added to the Context overlay that shows up when clicking on the date. To then have the document overlay show up, you could consult the drop function in document-upload.ts to see how it is handled there.

@rnicholus rnicholus linked a pull request Sep 28, 2024 that will close this issue
@rnicholus
Copy link

I have changes to support this at #1869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted platform:mobile Issues related to using Fava on mobile devices
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants