Skip to content

Commit

Permalink
lan743x: Remove MAC Reset from initialization
Browse files Browse the repository at this point in the history
The MAC Reset was noticed to erase important EEPROM settings.
It is also unnecessary since a chip wide reset was done earlier
in initialization, and that reset preserves EEPROM settings.

There for this patch removes the unnecessary MAC specific reset.

Signed-off-by: Bryan Whitehead <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
BryanW11731-MCHP authored and davem330 committed Dec 19, 2018
1 parent d9842f3 commit e0e5878
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/net/ethernet/microchip/lan743x_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -802,14 +802,8 @@ static int lan743x_mac_init(struct lan743x_adapter *adapter)
u32 mac_addr_hi = 0;
u32 mac_addr_lo = 0;
u32 data;
int ret;

netdev = adapter->netdev;
lan743x_csr_write(adapter, MAC_CR, MAC_CR_RST_);
ret = lan743x_csr_wait_for_bit(adapter, MAC_CR, MAC_CR_RST_,
0, 1000, 20000, 100);
if (ret)
return ret;

/* setup auto duplex, and speed detection */
data = lan743x_csr_read(adapter, MAC_CR);
Expand Down

0 comments on commit e0e5878

Please sign in to comment.