Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validation): Callout validation (Part 2) #19

Merged
merged 19 commits into from
Mar 1, 2024
Merged

Conversation

JumpLink
Copy link
Collaborator

@JumpLink JumpLink commented Feb 9, 2024

Make use of beabee-common validation methods for callout replay validation.

This PR requires the following PR for beabee-common: beabee-communityrm/beabee-common#9

@JumpLink JumpLink changed the title feat(validation): Callout validation (Part 2( feat(validation): Callout validation (Part 2) Feb 13, 2024
@JumpLink JumpLink requested a review from wpf500 February 29, 2024 09:41
@JumpLink JumpLink marked this pull request as ready for review February 29, 2024 13:45
Copy link
Member

@wpf500 wpf500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't fully understand what is going on and maybe I should spend a bit more time with the code, but I trust your skills so all good :)

@JumpLink JumpLink merged commit 5491dc3 into main Mar 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants