Fix update handler name to match the one defined in default vars #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good spot! |
iiegn
added a commit
to commul/ansible-role-ca-certificates
that referenced
this pull request
Nov 3, 2017
bdellegrazie
added a commit
that referenced
this pull request
Jan 23, 2018
Handlers are the correct solution to this type of problem but its difficult to get just this handler to run at the end of the role. Instead, provide a mechanism to execute the handler if the role changed. This will result in double handler execution but I'm not sure that can be avoided at this stage. Note that the handler name has been simplified to "update ca-certificates" closes #1
bdellegrazie
added a commit
that referenced
this pull request
Jan 23, 2018
Handlers are the correct solution to this type of problem but its difficult to get just this handler to run at the end of the role. Instead, provide a mechanism to execute the handler if the role changed. This will result in double handler execution but I'm not sure that can be avoided at this stage. Note that the handler name has been simplified to "update ca-certificates" Fixes #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fixes the update handler name to match the one defined in default vars.
Why?
Otherwise the playbook run fails..