Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ntlite-free] package is outdated #150

Closed
DJCrashdummy opened this issue Mar 6, 2020 · 11 comments
Closed

[ntlite-free] package is outdated #150

DJCrashdummy opened this issue Mar 6, 2020 · 11 comments
Assignees

Comments

@DJCrashdummy
Copy link

DJCrashdummy commented Mar 6, 2020

just a heads up, that ntlite-free 1.9.x is out now for about 2 months.

@DJCrashdummy
Copy link
Author

although the package ntlite-free is still not completely up to date, it now has at least a 1.9.x release...
it seems that the packaging is done manually... so there is nothing really which must be fixed, hence i'm going to close this issue.

@bcurran3 do you think it is possible to automize the packaging, that you have less work and the users get quicker updates?

@DJCrashdummy
Copy link
Author

btw: i get a checksum error for NTLite_setup_x64.exe. 😒

@DJCrashdummy
Copy link
Author

i just saw the "package notes": https://github.com/bcurran3/ChocolateyPackages/blob/master/ntlite-free/readme.md
...so i reopen this issue as requested by it.

@DJCrashdummy DJCrashdummy reopened this Apr 26, 2020
@bcurran3
Copy link
Owner

bcurran3 commented May 5, 2020

Would you like to be added as a maintainer?

@bcurran3 bcurran3 self-assigned this May 5, 2020
@bcurran3
Copy link
Owner

v1.9.0.7330 was packaged and pushed on 4/4 so I'm going to close this.
(Though there may be a newer version yet.)

@DJCrashdummy
Copy link
Author

DJCrashdummy commented Jun 16, 2020

sorry @bcurran3 for the late reply, i was pretty busy the last months.

i feel honored that you trust me enough to ask!
but to be honest i use windows (and therefore chocolatey) very occasionally and just for testing purposes. and on top of that i have no clue about packaging for chocolatey...

but sure, why not give you a hand every now and then, to speed things up... but to do so, please answer my questions which rose while i was looking into your repo:

  • it seems that the <version> at ntlite-free.nuspec is more or less irrelevant?
    <version>1.8.0.7217</version>
  • but at chocolateyinstall.ps1 and ChocolateyInstall.ps1 i'm anything else but sure:
    1. why these 2 similar files in general?
    2. why there are 2 files with identical URLs (i know they are perma-links for the latest version), but different checksums?
    3. are the checksums taken from the vendor or generated somewhere else? - if taken from the vendor (which i hope), why is sha256 specified in these files although the vendor provides only SHA-1?

@bcurran3
Copy link
Owner

Ignore the repo, it's completely out of whack.

If you want to help maintain, it's as simple as download the current nupkg from chocolatey.org, extract it (it's a .ZIP), edit the version and edit the checksum, run cpack, and then cpush. It's that simple.

@DJCrashdummy
Copy link
Author

Ignore the repo, it's completely out of whack.

ok... that explains a lot. 😉

If you want to help maintain, it's as simple as download the current nupkg from chocolatey.org, extract it (it's a .ZIP), edit the version and edit the checksum, run cpack, and then cpush.

thanks a lot for pointing me at choco pack and choco push!
it would be kind, if you can still confirm/answer the folowing:

  1. ok, so <version> at ntlite-free.nuspec is not irrelevant and must be changed.
  2. why aren't the checksums at chocolateyinstall.ps1 taken from the vendor? - that would make the process easily comprehensible and completely transparent... 🤔
  3. last but not least: is there also a possibility to contribute without having a windows running? - as said, i'm running windows just every now and then for testing... but i sometimes notice outdated choco-packages at other users machines. 😑

@bcurran3
Copy link
Owner

  • version in the nuspec is where you put the package version which is usually same as the program version; it is 100% relevant.
  • checksums from the vendor are fine to use, just need to change the checksumtype to match. I always use and create my own SHA2565 checksums. Rob/FerventCoder has a checksum program that I use with an alias to make it simple for me (don't have to remember all the damn parameters!).
  • cpack and cpush run under Windows Command Prompt, they are needed. They may/may not work with mono.

@TheCakeIsNaOH
Copy link
Contributor

last but not least: is there also a possibility to contribute without having a windows running? - as said, i'm running windows just every now and then for testing... but i sometimes notice outdated choco-packages at other users machines. 😑

Yes, it is possible @DJCrashdummy.

You can build the docker container with it yourself, or build with mono. There is also this customized prebuilt container, although it has a bit of weird behavior.

I would suggest at least mono 5.20, and the mono 6.8 is working just fine personally.

If you are building it outside of the docker container, here are some more steps to get everything working properly.

choco pack and choco push are working fine. cpack and cpush are windows only aliases, though there is no reason you cannot recreate them in your shell if wanted. choco install also "works", but it only unpacks the files and does not run the powershell scripts, kind of like nuget install. The other commands such as feature and source are working as well, at least as far as I have tested.

@DJCrashdummy
Copy link
Author

I always use and create my own SHA2565 checksums. Rob/FerventCoder has a checksum program that I use with an alias to make it simple for me (don't have to remember all the damn parameters!).

i still don't get it how downloading, "verifying" the downloaded file with the vendors checksum and then creating a SHA256 of the download is easier, than just copy&pasting the vendors checksum... 🤔 but anyhow, as i hardly ever use windows i also have no clue how easy/hard it is to generate a checksum there; i'm happy with md5sum, sha1sum, sha256sum etc. on nearly all *nix, which usually don't need any parameter. 😉

You can build the docker container with it yourself, or build with mono. There is also this customized prebuilt container, although it has a bit of weird behavior.

@TheCakeIsNaOH thanks for pointing me far down the readme... i haven't looked there so far (yet).

i'm not using docker on my everyday notebook and also try to avoid mono... but lets see if i'll start fiddling around with mono (once again), end with occasionally firing up a VM or nevertheless use docker. 😑

cpack and cpush are windows only aliases, though there is no reason you cannot recreate them in your shell if wanted.

alias are the least issues and pretty easy to solve... if only this were the biggest issues, i'd be happy. 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants