Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AngryIP depend on a openJDK JRE rather then Oracle JRE #142

Closed
TheCakeIsNaOH opened this issue Jan 8, 2020 · 8 comments
Closed

AngryIP depend on a openJDK JRE rather then Oracle JRE #142

TheCakeIsNaOH opened this issue Jan 8, 2020 · 8 comments
Assignees

Comments

@TheCakeIsNaOH
Copy link
Contributor

Due to Oracle licensing changes prohibiting business use.

I would suggest switching the AngryIP java dependency to an AdoptOpenJDK build, probably this one- https://chocolatey.org/packages/adoptopenjdk8jre

@bcurran3
Copy link
Owner

IMHO most of the world uses's Oracle's (Sun's!) version of JAVA. I don't really like the idea of switching away from it unless I see (proof?) of the trend changing.

@TheCakeIsNaOH
Copy link
Contributor Author

The chocolatey core team has moved to OpenJDK
chocolatey-community/chocolatey-packages#1315

The other package that I know about that depends on Java has switched to AdoptOpenJDK-
wjk/BFG-Windows#3

@ctminime
Copy link

ctminime commented Jul 16, 2020

IMHO most of the world uses's Oracle's (Sun's!) version of JAVA. I don't really like the idea of switching away from it unless I see (proof?) of the trend changing.

Seriously? Every company that I know of is moving away from Oracle Java. Even the default Java package for Redhat, Debian, and Arch based distros have moved away from Oracle Java (see references below). Even running JUST the Oracle JRE within a business requires you to pay for it (Oracle Java's licensing link below clearly states that the JRE is free for personal use but not bussiness).

So, IMHO those 3 distros (which are the parents of most other distros) moving away from Oracle Java is proof of a trend change.

https://wiki.debian.org/Java

https://access.redhat.com/documentation/en-us/jboss_enterprise_application_platform/6/html/administration_and_configuration_guide/configure_the_default_jdk_on_red_hat_enterprise_linux

https://wiki.archlinux.org/index.php/Java

https://www.oracle.com/technetwork/java/javase/overview/oracle-jdk-faqs.html

@bcurran3
Copy link
Owner

bcurran3 commented Jul 17, 2020

@TheCakeIsNaOH

They had a discussion about it, but from what I read they have no packages with a Java dependency.

@ctminime

Seriously!

I'm not catering to companies, I'm catering to normal Chocolatey FOSS users. If you're working for a company using Chocolatey, you should be using Chocolatey 4 Business. If you're working for a company with an IT department you should be using Chocolatey 4 Business and the IT department should be using company created packages (with whatever Java dependency you prefer.)

I completely understand your point of view, and the reasons related to Oracle's new licensing. I just see the package for Joe Average. OK, I'll admit that Joe Average probably has no need for AngryIP though.

Oracle's Java is still the defacto standard; anything else is an alternate/substitution. They, via proxy by buying Sun ("The network is the computer."), invented it.

With that said I have a number of packages that require Java and have it as a dependency. It will take time and effort to refactor something that already works using the standard to test and see if it will work with an alternative version. This is not about one package, this is about testing all the programs that I personally use that require Java and see if they will transition and still work. This is not just about this package. ATM I don' t know if I can have dual versions of Java installed and no conflicts. It's not about switching one package, it's about ultimately switching at least a dozen packages including a few that are in no longer development.

Honestly I'm more inclined to drop the dependency altogether and just make a disclaimer that you need some form of Java installed. I guess I could have the script check for the various Java packages and display some message if nothing is found. Needs some thinking. If all the various vendor versions of Java are compatible and interchangeable, what would be really nice is a meta package that lists all of them and if you have any one of them installed, it passes. I don't think Chocolatey has the built-in OR logic for it though...

Since this has been open for awhile and I'm in no rush to change what works ("If it ain't broke, don't fix it."), I'm going to record a statistical snapshot in time to help watch the "trend" to see about making a more informed decision at a future date. This seems to me to be a fair way to do this. At the moment the vote to change the Java dependency is 2 with 3,479 abstain.

image

image

We can now use those download stats as a historical record from today and compare them to the stats in a month, two, three, six, a year or such and see what is trending. As of today it's basically 15 million to 74 thousand, but that's not fair since Oracle's license changed towards the end of 2019. So let's watch and see what happens.

@TheCakeIsNaOH
Copy link
Contributor Author

As a compromise, how about using the Oracle OpenJDK? It is still Oracle Java, but it is a build licensed under GPLv2 rather than their other EULA that prohibits business use without payment.
https://chocolatey.org/packages/openjdk8jre

@bcurran3 bcurran3 added the Hold label Jul 19, 2020
@TheCakeIsNaOH
Copy link
Contributor Author

Honestly I'm more inclined to drop the dependency altogether and just make a disclaimer that you need some form of Java installed.

Given that there has been no movement on chocolatey/choco#858, and given the number of backloged items that would need to be dealt with first, I'm kind of leaning toward this option these days.

The install script could do a Get-Command java.exe, and if java is not on the path, then print out a big, red(or yellow), warning that java needs to be installed manually. I'm doing something similar with javac.exe to check for a java compiler in the maven package: https://github.com/TheCakeIsNaOH/chocolatey-packages/blob/master/maven/tools/chocolateyinstall.ps1#L22-L24

I REALLY want provides to be implemented in the .nuspec, working around it's absence for java is getting annoying.

@bcurran3
Copy link
Owner

bcurran3 commented Feb 6, 2022

From 3.8.2 release notes:
* Windows installer now includes a stripped-down JRE to avoid downloading Java separately

This has been decided for us by the dev; as of v 3.8.2 a JRE (Liberica?) is included in the installer by default. Problem solved externally.

@bcurran3 bcurran3 closed this as completed Feb 6, 2022
@TheCakeIsNaOH
Copy link
Contributor Author

@bcurran3 thanks for keeping up to date with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants