Add an EditorConfig and clean up readme #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: introducing these changes raises a question in the coveralls example at the bottom: does `nyc` really need to be run again for the report to be available? and wouldn’t it be better just to have the lcov report generated alongside the regular text display, and have the `after_success` command just `cat` and pipe it to `coveralls`?
|
@bcoe please advise and I'll update :) |
|
It's important to note that running the tests outputs coverage info as JSON in
Does not re-run tests. So this approach is fast, and quite similar to simply using One lovely advantage of letting the Thank you for this contribution \o/ I hope that you'll continue to contribute more as you work with |
bcoe
added a commit
that referenced
this pull request
Mar 1, 2016
Add an EditorConfig and clean up readme
|
@JaKXz give this a shot:
shipped with your editor config changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: introducing these changes raises a question in the coveralls
example at the bottom: does
nycreally need to be run again for thereport to be available? and wouldn’t it be better just to have the lcov
report generated alongside the regular text display, and have the
after_successcommand justcatand pipe it tocoveralls?