Don't instrument files outside of the current working directory

[novemberborn]

Files outside of the current working directory (meaning higher up in the file hierarchy) should not be instrumented.

Fixes #157 where nyc is run from inside a node_modules directory.

Fixes #154 where 'npm link' is used to fulfil dependencies.

This removes matching the include/exclude patterns to the absolute filename, the patterns are now applied only to the relative portion within the current working directory.

addAllFiles() has been changed to explicitly add files in the current working directory only.

Some other tests related to include/exclude behavior have been cleaned up.

---

Note that I'm not entirely certain filename in shouldInstrumentFile() is always absolute. Review on that front would be especially appreciated.

This changes the include/exclude matching behavior, but restricting it to the cwd makes more sense to me.

[bcoe]

@novemberborn great work; I'll do a thorough test on a few platforms/projects and we can release this to a next tag ASAP.

[novemberborn]

I'll do a thorough test on a few platforms/projects and we can release this to a next tag ASAP.

Great!

[bcoe]

@novemberborn starting doing a little bit of testing, this patch doesn't seem to be working for a linked module:

One other thing we might want to be mindful of is this logic:

relFile = relFile.replace(/^\.\//, '') // remove leading './'.

We should probably be using path.sep for the benefit of Windows.

[bcoe]

@novemberborn the good news, is I saw that this patch solves the issues @micnic was having \o/

[jamestalmage]

We should probably be using path.sep

Or just account for either slash in the regexp

str.replace(/\.[\\\/]/, '')

Using path.sep in a regexp is painfull

[sindresorhus]

Or just account for either slash in the regexp

👍

[novemberborn]

@bcoe

starting doing a little bit of testing, this patch doesn't seem to be working for a linked module

Ha, this is a nice one! I reproduced this by cloning https://github.com/bcoe/yargs/tree/split-out-parser and https://github.com/yargs/yargs-parser/tree/require.main.filename into sibling directories, then npm linking yargs-parser into yargs.

Turns out when you have paths like these:

/var/folders/_6/p8qxp_3n62zg9081tvb0lcc80000gn/T/tmp.NOCrQG1U/yargs
/var/folders/_6/p8qxp_3n62zg9081tvb0lcc80000gn/T/tmp.NOCrQG1U/yargs-parser

'yars-parser'.indexOf('yars') does return 0, so yargs-parser was included. I've (force-)pushed a fix which checks if path.relative(this.cwd, filename) returns a string that starts with ... I was being lazy with indexOf.

We should probably be using path.sep for the benefit of Windows.

Pushed a commit which fixes that, using @jamestalmage's method.

[bcoe]

lol @novemberborn that's great, as usual I manage to be a nightmare user of our own library and find a crazy edge-case: