Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AppVeyor config with ~faster npm install #252

Merged
merged 2 commits into from
May 23, 2016

Conversation

JaKXz
Copy link
Member

@JaKXz JaKXz commented May 8, 2016

Only test against stable and LTS versions of node since AppVeyor goes pretty slow.

@bcoe I noticed that after dropping the Travis build times to 1/4th of what they were on Travis in #251, AppVeyor's build takes even longer... so this is an attempt to streamline it by using the version of npm that comes with each node distro and only going for stable and LTS versions. Thoughts?

Only test against stable and LTS versions of node since AppVeyor goes pretty slow.
@bcoe
Copy link
Member

bcoe commented May 9, 2016

@JaKXz this seems to be failing, kicked off the build twice. Perhaps try adding back the npm update, and see if this helps; if not, we might not be able to pull in 6.x yet.

@JaKXz
Copy link
Member Author

JaKXz commented May 10, 2016

@bcoe I don't think the npm update is what's broken here, since node@6 comes with a version that I'm pretty sure npm install -g npm@latest would install [at time of writing] - see the AppVeyor logs around line 507:

node --version
v6.1.0
npm --version
3.8.6

Though I'm not sure why it would pass on Travis and not AppVeyor with node@6.

@bcoe
Copy link
Member

bcoe commented May 14, 2016

@JaKXz I think we'll need to spin up a Windows VM to test this one out.

@jamestalmage
Copy link
Member

Probably related to:
avajs/ava#814

@JaKXz
Copy link
Member Author

JaKXz commented May 23, 2016

whoa it's passing now... 🎱

@jamestalmage
Copy link
Member

Yes. Node 6.2.0 reverted a regression that almost certainly affected this.

@jamestalmage
Copy link
Member

0.12 remains in LTS mode through the end of the year. We should not drop it yet.

@bcoe
Copy link
Member

bcoe commented May 23, 2016

@JaKXz interesting that it started working, maybe the version of 6 was updated.

@bcoe bcoe merged commit df591f4 into istanbuljs:master May 23, 2016
@JaKXz JaKXz deleted the patch-2 branch May 23, 2016 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants