Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart Improvements #657

Merged
merged 8 commits into from
Oct 23, 2024
Merged

Helm Chart Improvements #657

merged 8 commits into from
Oct 23, 2024

Conversation

i5okie
Copy link
Contributor

@i5okie i5okie commented Oct 9, 2024

  • Do not create the database secret, use the secret created by PostgreSQL chart itself when enabled.
  • Update Values file
  • Update _helpers
  • Update and clean up Readme

Note:
When installing with a custom release name that does not contain "vc-authn-oidc", the user must set fullNameOverride.

@i5okie i5okie requested a review from esune October 9, 2024 18:52
@i5okie i5okie self-assigned this Oct 9, 2024
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Are you going to coordinate the (manual) updates that need to happen in dev when switching to this release (i.e.: as soon as it is merged to main) as well as for test/prod in the near future?

@i5okie i5okie changed the title Helm Chart Improvements Helm Chart Improvements [Do Not Merge] Oct 10, 2024
@i5okie i5okie changed the title Helm Chart Improvements [Do Not Merge] Helm Chart Improvements Oct 23, 2024
@i5okie i5okie merged commit 2312b53 into main Oct 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants