Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Helm} Chart changes to support ArgoCD deployment #522

Merged
merged 20 commits into from
May 28, 2024
Merged

[Helm} Chart changes to support ArgoCD deployment #522

merged 20 commits into from
May 28, 2024

Conversation

i5okie
Copy link
Contributor

@i5okie i5okie commented May 17, 2024 •
edited by esune
Loading

Resolves #447

@i5okie
Increase agent database storage volume.
38edfc0 
Signed-off-by: Ivan Polchenko <[email protected]>
@i5okie
helpers file changes, add createsecret logic
e1adb3b 
Signed-off-by: Ivan Polchenko <[email protected]>
@i5okie
create secret only if necessary
0514e23 
Signed-off-by: Ivan Polchenko <[email protected]>
@i5okie
Allow specifying existingSecret
522b837 
Signed-off-by: Ivan Polchenko <[email protected]>
@i5okie
Update Readme
e0f348c 
Signed-off-by: Ivan Polchenko <[email protected]>
@i5okie
use secret keys as defined in Values
3c40da8 
Signed-off-by: Ivan Polchenko <[email protected]>
@i5okie
Merge branch 'main' of https://github.com/bcgov/vc-authn-oidc into fe…
689bb7a 
…ature/chart-update
@i5okie
Use latest MongoDB chart
d6d9a18 
Signed-off-by: Ivan Polchenko <[email protected]>
@i5okie
bump version
0b00e32 
Signed-off-by: Ivan Polchenko <[email protected]>
@i5okie i5okie self-assigned this May 17, 2024
@i5okie i5okie requested a review from esune May 17, 2024 16:03
@i5okie
Use 5Gi instead of 8
92ed50c 
Signed-off-by: Ivan Polchenko <[email protected]>
@i5okie i5okie mentioned this pull request May 17, 2024
Closed
esune
esune previously approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Do we need to update anything here as well?

@i5okie
Copy link
Contributor Author

i5okie commented May 24, 2024 •
edited
Loading

LGTM 👍🏻

Do we need to update anything here as well?

The existing values files do not need to be updated. They will need to be updated when used with ArgoCD.

@i5okie i5okie requested a review from esune May 27, 2024 18:33
@i5okie
clean up network policy apiVersion
00c7810 
Signed-off-by: Ivan Polchenko <[email protected]>
@i5okie
remove redundant logic
0fd582e 
Signed-off-by: Ivan Polchenko <[email protected]>
@i5okie
fix helpers logic
a2da178 
Signed-off-by: Ivan Polchenko <[email protected]>
@i5okie
add auth.api.existingSecret, update Readme
3b7936d 
Signed-off-by: Ivan Polchenko <[email protected]>
@i5okie
Clean up secrets
5d9ffd9 
Signed-off-by: Ivan Polchenko <[email protected]>
@i5okie
Update dependencies
9eeff6d 
Signed-off-by: Ivan Polchenko <[email protected]>
esune
esune approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looking good to me. I assume they have been tested throughly already?

@loneil
Copy link
Contributor

loneil commented May 28, 2024

Think I'm reading the Bitnami chart correctly, this is going to Mongo 7.0.9 right? Just that local docker compose is on moongo:6.0 so we could update and test that as well

@i5okie i5okie merged commit 2804ef3 into bcgov:main May 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esune esune esune approved these changes

Assignees

@i5okie i5okie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Helm Chart to add ArgoCD deployment compatibility
3 participants
@i5okie @loneil @esune