Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can scan a QR code while it's in Pending state #520

Closed
loneil opened this issue May 15, 2024 · 5 comments
Closed

Can scan a QR code while it's in Pending state #520

loneil opened this issue May 15, 2024 · 5 comments
Assignees

Comments

@loneil
Copy link
Contributor

loneil commented May 15, 2024

The mask over the QR code does not obscure it enough to prevent (at least the BC Wallet) from attempting to scan it as a QR code. This can have unintended consequences it seems (depending on BC Wallet build/OS can result in Invalid QR code, or an attempt to do the proof that doesn't work)

This mask should probably obscure the QR code more?

image

@loneil
Copy link
Contributor Author

loneil commented May 15, 2024

For example, on Android (1707) doing multiple scans and then denying the one that comes up can result in:

image

@esune esune moved this to Assignment Ready in CDT Enterprise Apps May 16, 2024
@loneil
Copy link
Contributor Author

loneil commented May 16, 2024

Don't have the issue on "Refresh" state as the text box blocks more

image

@loneil loneil self-assigned this May 17, 2024
@loneil loneil moved this from Assignment Ready to Assigned in CDT Enterprise Apps May 17, 2024
@knguyenBC
Copy link

knguyenBC commented May 22, 2024

Adding an opaque border around the "QR code scanned" will make it look like a button that people may click. I would suggest blurring the QR code or simply increase the transparency (make the qr code lighter). Also, there's a transparency treatment on the text as well, that should be removed.

@esune
Copy link
Member

esune commented May 22, 2024

@loneil if the effort is not significant let's implement Kim's recommendations before we close the issue.

@loneil loneil moved this from Assigned to In Review in CDT Enterprise Apps Jun 7, 2024
@loneil
Copy link
Contributor Author

loneil commented Jun 7, 2024

Changes in #540
QR is lighter and unscannable. Text is normal opaque text now so no button confusion

@loneil loneil closed this as completed Jun 7, 2024
@github-project-automation github-project-automation bot moved this from In Review to Complete in CDT Enterprise Apps Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants