-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can scan a QR code while it's in Pending state #520
Comments
Adding an opaque border around the "QR code scanned" will make it look like a button that people may click. I would suggest blurring the QR code or simply increase the transparency (make the qr code lighter). Also, there's a transparency treatment on the text as well, that should be removed. |
@loneil if the effort is not significant let's implement Kim's recommendations before we close the issue. |
Changes in #540 |
The mask over the QR code does not obscure it enough to prevent (at least the BC Wallet) from attempting to scan it as a QR code. This can have unintended consequences it seems (depending on BC Wallet build/OS can result in Invalid QR code, or an attempt to do the proof that doesn't work)
This mask should probably obscure the QR code more?
The text was updated successfully, but these errors were encountered: