Create UI: Amalgamating Businesses component - Part 3b (remaining validations)

[severinbeauvais]

This is the second part of ticket #18640. That ticket's estimate of 8 has been reduced to 5, and this ticket is estimated as 3.

• implement basic validations (Yui's original table of 6 rules)
• implement advanced amalgamating businesses validations (see Google doc link below)
• add tooltip to "Ready" values (see business list in uxpin)

Google doc: https://docs.google.com/document/d/1Dt2jzPA2SLtQO7Ns2aPCzVchGdv4YrYB/edit

[severinbeauvais]

@yuisotozaki This is the new ticket I'm working on. As part of this ticket:

• what do you think about the snackbar?
• what do you think about the spinner?

[yuisotozaki]

I have to pass the snackbar by the design team. I know we use them but accessibility support isn't good. We don't want to introduce widgets that we'll need to undo later.
As for the spinner - do we use it elsewhere?

[severinbeauvais]

I'm open to alternate designs for add error messaging.

Yes, we use the spinner in multiple UI/filings when we need to fetch additional data from the API. << a good example of this is clicking "View Documents" for any ledger items -- it goes and fetches the documents list and any comments the first time you click on this item

[severinbeauvais]

@riyazuddinsyed This ticket is tagged to multiple releases because it has content in several releases (due to multiple, incremental PRs).

[severinbeauvais]

This is ready for UX Assurance.

Sample amalgamation applications (try as BCREG0020 and staff):
https://dev.create.business.bcregistry.gov.bc.ca/amalg-reg-information?id=Tc2caJYQrz
https://dev.create.business.bcregistry.gov.bc.ca/amalg-reg-information?id=TD2mgyjRd1
(or create your own!)

Yui, if you don't like the spinner or the snackbar, please create a new ticket. Thx.

For a detailed look at the implemented validation rules, see this code:
https://github.com/bcgov/business-create-ui/blob/main/src/mixins/amalgamation-mixin.ts#L25

[yuisotozaki]

Observation:

• Replace the "Close" label on the snackbar with an ex icon in white. This is how the MBR list works when a new row is added successfully.

[severinbeauvais]

This will be done in #18788.

[yuisotozaki]

Ready for QA.