Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statement settings always hidden #18761

Closed
ochiu opened this issue Nov 27, 2023 · 2 comments
Closed

Statement settings always hidden #18761

ochiu opened this issue Nov 27, 2023 · 2 comments
Assignees
Labels
Pay Work for Pay Team

Comments

@ochiu
Copy link
Collaborator

ochiu commented Nov 27, 2023

The current implementation to hide the statement settings when EFT payment method selected is incorrect.

The implementation is based on the EFT enabled feature flag only. The settings are hidden if the feature flag is enabled, but we want to show the settings for non EFT payment methods when the feature flag is enabled.

See:
https://github.com/bcgov/sbc-auth/blob/main/auth-web/src/components/auth/account-settings/statement/Statements.vue#L21

Update:
Based on discussions, the statement settings will always be available, but for EFT the statement frequency is locked to MONTHLY

@ochiu ochiu added the Pay Work for Pay Team label Nov 27, 2023
@ochiu ochiu mentioned this issue Nov 27, 2023
14 tasks
@seeker25
Copy link
Collaborator

Hey team! Please add your planning poker estimate with Zenhub @Jxio @ochiu @rodrigo-barraza

@seeker25
Copy link
Collaborator

Confirmed the settings are still working, haven't tried with EFT. EFT is feature flagged.

@PCC199 PCC199 closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pay Work for Pay Team
Projects
None yet
Development

No branches or pull requests

3 participants