Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Bug - Sale/Gift now missing autoscroll and red bar validation when there are no owners #18364

Closed
tlebedovich opened this issue Oct 26, 2023 · 16 comments
Assignees
Labels
Assets bug Something isn't working

Comments

@tlebedovich
Copy link

tlebedovich commented Oct 26, 2023

in DEV

Staff and Qualified Suppliers

IF you start a Sale/Gift transfer
THEN you delete all of the existing owners
AND complete all of the transfer details info
AND click Review and Confirm
THEN the red bar on the homeowner table and autoscroll to homeowners table is now missing:

Screen Shot 2023-10-26 at 4 45 33 PM

@dimak1
Copy link
Collaborator

dimak1 commented Jun 17, 2024

@LizGovier this might be a verify ticket, but want to confirm some functionality. When there is only one owner, removing via Delete All Owners is slightly different than Delete single owner button. The 'No owners added yet' message shows up only when removing via Delete All.

Screenshot 2024-06-17 at 02.37.32.png

Screenshot 2024-06-17 at 02.37.47.png

Since this was reviewed and tested multiple times, is this an actual bug? If not, we can move this ticket to RFQA to verification of original issue.
Thanks!

@LizGovier
Copy link
Collaborator

Hey @dimak1 'No owners added yet' should appear for both 'Delete all Owners/Groups' and deleting all owners manually with 'Delete Owner'

@dimak1
Copy link
Collaborator

dimak1 commented Jun 17, 2024

I got the message showing, but the styling is broken, and test is failing. Will take a look further.

Screenshot 2024-06-17 at 15.17.43.png

@dimak1
Copy link
Collaborator

dimak1 commented Jun 27, 2024

@LizGovier adding 'No owners added yet.' message as below, fails a unit test that was updated as part of Transfers Bugs ticket #20884. In other words, the message should not be there, because it was specifically unit tested in 20884. There was a reason for it...

Do we need to change it back and add the message & update the test?

Screenshot 2024-06-27 at 08.45.24.png

@dimak1 dimak1 assigned LizGovier and unassigned dimak1 Jun 27, 2024
@dimak1
Copy link
Collaborator

dimak1 commented Jun 27, 2024

Assigned to @LizGovier for comment.

@LizGovier
Copy link
Collaborator

@dimak1 I'm not quite sure what you mean when you say adding 'No Owners Added yet' fails a unit test that was updated as part of Transfers Bugs ticket #20884. I didn't see any reference to 'No Owners Added yet' and why this was removed.

@dimak1
Copy link
Collaborator

dimak1 commented Jun 27, 2024

@LizGovier we have a unit test that specifically tests that 'No Owners' message should not be shown. I don't know the original reason for it, just saying what I see in the code.
If required, I could update it and show the 'No Owners' message. We would have to do a regression, because I don't know if anything else (other Transfer Types/Flows) would be affected. Would you like me to add the 'No Owners' message back?

@LizGovier
Copy link
Collaborator

@dimak1 If we do not add this message in, then we're not informing the user of the issue and they may not know what to do. I would add the text back in for bill of sale and other transfers and then do regression testing. However it sounds like would increase the scope of this ticket.

@arlentees Because this may increase the scope of this ticket, would it be ok to move forward with adding this text and do a regression. To give you a summary, we have rules in place where a message appears 'No Owners Added yet' in a bill of sale transfer or other transfers if all owners have been deleted and no new owner has been added. Dima mentioned above that this message was removed at some point, but we're not sure why, which means maybe it was causing an issue with another transfer type.

@arlentees
Copy link
Collaborator

@LizGovier @dimak1 I'm ok to have a small increase in scope on this, it sounds like it's needed to ensure the work is properly validated in unit tests.

@chdivyareddy
Copy link
Collaborator

Hey @dimak1 , the above scenario looks good in DEV, but when there is a Tenants in Common structure, deleting owners in the group deletes the group as well. Please take a look, thanks!

Steps to reproduce:

  • Select MHR 107985 in DEV and click open
  • Navigate to home owners component and select transfer due to sale/gift
  • Delete all the owners individually from the group by clicking on the Delete owner button instead of Delete Group button
  • Group will be automatically deleted

Current behavior:

Private Zenhub Video

Expected Behavior:
image.png

@dimak1
Copy link
Collaborator

dimak1 commented Jul 2, 2024

Fixed and ready in DEV.

@dimak1 dimak1 removed their assignment Jul 2, 2024
@chdivyareddy
Copy link
Collaborator

chdivyareddy commented Jul 2, 2024

@dimak1 , looks like a validation bug..Please take a look, thanks!

  • When all the groups are deleted in a Tenants in Common structure and a sole owner is added, then the user is not taken to the review screen:
    MHR 107985 in DEV:

image.png

@chdivyareddy chdivyareddy assigned dimak1 and unassigned chdivyareddy Jul 2, 2024
@dimak1
Copy link
Collaborator

dimak1 commented Jul 2, 2024

Hi @chdivyareddy, I checked, and this is an existing bug (not introduced with this fix). I was able to reproduce in TEST using MHR 108192. I will look into it as part of this ticket, if you ok with it.
Screenshot 2024-07-02 at 15.17.21.png

@chdivyareddy
Copy link
Collaborator

@dimak1 , thanks for checking! Sure, please go ahead with the fix in this ticket.

@dimak1
Copy link
Collaborator

dimak1 commented Jul 3, 2024

Ready in DEV.

@dimak1 dimak1 assigned chdivyareddy and unassigned dimak1 Jul 3, 2024
@chdivyareddy
Copy link
Collaborator

Verified in DEV!

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assets bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants