-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Bug - Sale/Gift now missing autoscroll and red bar validation when there are no owners #18364
Comments
@LizGovier this might be a verify ticket, but want to confirm some functionality. When there is only one owner, removing via Delete All Owners is slightly different than Delete single owner button. The 'No owners added yet' message shows up only when removing via Delete All. Since this was reviewed and tested multiple times, is this an actual bug? If not, we can move this ticket to RFQA to verification of original issue. |
Hey @dimak1 'No owners added yet' should appear for both 'Delete all Owners/Groups' and deleting all owners manually with 'Delete Owner' |
@LizGovier adding 'No owners added yet.' message as below, fails a unit test that was updated as part of Transfers Bugs ticket #20884. In other words, the message should not be there, because it was specifically unit tested in 20884. There was a reason for it... Do we need to change it back and add the message & update the test? |
Assigned to @LizGovier for comment. |
@LizGovier we have a unit test that specifically tests that 'No Owners' message should not be shown. I don't know the original reason for it, just saying what I see in the code. |
@dimak1 If we do not add this message in, then we're not informing the user of the issue and they may not know what to do. I would add the text back in for bill of sale and other transfers and then do regression testing. However it sounds like would increase the scope of this ticket. @arlentees Because this may increase the scope of this ticket, would it be ok to move forward with adding this text and do a regression. To give you a summary, we have rules in place where a message appears 'No Owners Added yet' in a bill of sale transfer or other transfers if all owners have been deleted and no new owner has been added. Dima mentioned above that this message was removed at some point, but we're not sure why, which means maybe it was causing an issue with another transfer type. |
@LizGovier @dimak1 I'm ok to have a small increase in scope on this, it sounds like it's needed to ensure the work is properly validated in unit tests. |
Hey @dimak1 , the above scenario looks good in DEV, but when there is a Tenants in Common structure, deleting owners in the group deletes the group as well. Please take a look, thanks! Steps to reproduce:
Current behavior: |
Fixed and ready in DEV. |
@dimak1 , looks like a validation bug..Please take a look, thanks!
|
Hi @chdivyareddy, I checked, and this is an existing bug (not introduced with this fix). I was able to reproduce in TEST using MHR 108192. I will look into it as part of this ticket, if you ok with it. |
@dimak1 , thanks for checking! Sure, please go ahead with the fix in this ticket. |
Ready in DEV. |
in DEV
Staff and Qualified Suppliers
IF you start a Sale/Gift transfer
THEN you delete all of the existing owners
AND complete all of the transfer details info
AND click Review and Confirm
THEN the red bar on the homeowner table and autoscroll to homeowners table is now missing:
The text was updated successfully, but these errors were encountered: