Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate - Expired NR showing up as "Approved" on NR results page #18301

Closed
oanyahuru opened this issue Oct 24, 2023 · 15 comments
Closed

Investigate - Expired NR showing up as "Approved" on NR results page #18301

oanyahuru opened this issue Oct 24, 2023 · 15 comments
Labels
Names Team Name Request Name Examination Team Priority1

Comments

@oanyahuru
Copy link
Collaborator

While testing NR 'expiring soon' and 'expired' letters, I noticed that the letters still show up as approved a day after expiry

@oanyahuru oanyahuru added the Names Team Name Request Name Examination Team label Oct 24, 2023
@oanyahuru
Copy link
Collaborator Author

From NR
image

Time was 10.25am, Tuesday, October 24th 2023 (Pacific Time)

@oanyahuru oanyahuru changed the title NR expired letter showing up as "Approved" Expired NR showing up as "Approved" on NR results page Oct 24, 2023
@PCC199
Copy link
Collaborator

PCC199 commented Oct 26, 2023

Please investigate NR job to confirm that approved name requests are being expired within 24hrs

@PCC199 PCC199 changed the title Expired NR showing up as "Approved" on NR results page Investigate - Expired NR showing up as "Approved" on NR results page Oct 26, 2023
@Rajandeep98 Rajandeep98 self-assigned this Oct 30, 2023
@Rajandeep98
Copy link
Collaborator

Private Zenhub Image

@Rajandeep98
Copy link
Collaborator

job runs to update expired state everyday 8:14am acc to UTC, expiration date shows in events / user screen is not in pst but in utc
Private Zenhub Image

Private Zenhub Image

@oanyahuru
Copy link
Collaborator Author

@Rajandeep98 as discussed, there are two issues that need to be addressed. The first point is that the time zones should follow a common format (either all Pacific or all UTC). @ozamani9gh we need a decision on this to avoid the time mismatch.

Secondly, even with both the "last update time" and the "expiry date/time" in UTC, there is still a time disparity greater than 24 hours.
image

@Rajandeep98 can you please investigate if it would be possible to adjust the run times (as discussed earlier) to enable the expiry letters get published earlier.

@Rajandeep98
Copy link
Collaborator

from code: found that last_update column (job updating expired status) is saving as UTC, however, expiration_date column as PST, so, the time will not go over 24 hours:
Private Zenhub Image

@Rajandeep98
Copy link
Collaborator

query updated results:
Private Zenhub Image

@Rajandeep98
Copy link
Collaborator

the difference on the user screen for expired status comes as of this above timezone difference

@ozamani9gh
Copy link
Collaborator

@Rajandeep98 the end result the conversion needs to follow UTC and TZ so every expiry date and time, is 56 DAY at 11:59PM.

or if its restored and reinstated, 1 YEAR 56 DAYS at 11:59pm.

it must be 11:59pm

@ozamani9gh ozamani9gh removed the On Hold label Nov 9, 2023
@eve-git
Copy link
Collaborator

eve-git commented Nov 24, 2023

I believe it is the same issue as in #18567.

@oanyahuru @Rajandeep98 @ozamani9gh what do you think?

@oanyahuru
Copy link
Collaborator Author

image.png

I checked this morning and the tickets that were supposed to expire yesterday are still showing as Active. They will expire when the job runs tomorrow morning

@eve-git
Copy link
Collaborator

eve-git commented Dec 4, 2023

The reason is the nr-day-job in test is scheduled at 8:14am (16:14 UTC):
image

@eve-git
Copy link
Collaborator

eve-git commented Dec 4, 2023

@oanyahuru your testing nr is expired:
image

@oanyahuru
Copy link
Collaborator Author

Ok, it has expired now. this just came in
image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Names Team Name Request Name Examination Team Priority1
Projects
None yet
Development

No branches or pull requests

5 participants