-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate - Expired NR showing up as "Approved" on NR results page #18301
Comments
Please investigate NR job to confirm that approved name requests are being expired within 24hrs |
job runs to update expired state everyday 8:14am acc to UTC, expiration date shows in events / user screen is not in pst but in utc |
@Rajandeep98 as discussed, there are two issues that need to be addressed. The first point is that the time zones should follow a common format (either all Pacific or all UTC). @ozamani9gh we need a decision on this to avoid the time mismatch. Secondly, even with both the "last update time" and the "expiry date/time" in UTC, there is still a time disparity greater than 24 hours. @Rajandeep98 can you please investigate if it would be possible to adjust the run times (as discussed earlier) to enable the expiry letters get published earlier. |
from code: found that last_update column (job updating expired status) is saving as UTC, however, expiration_date column as PST, so, the time will not go over 24 hours: |
query updated results: |
the difference on the user screen for expired status comes as of this above timezone difference |
@Rajandeep98 the end result the conversion needs to follow UTC and TZ so every expiry date and time, is 56 DAY at 11:59PM. or if its restored and reinstated, 1 YEAR 56 DAYS at 11:59pm. it must be 11:59pm |
I believe it is the same issue as in #18567. @oanyahuru @Rajandeep98 @ozamani9gh what do you think? |
@oanyahuru your testing nr is expired: |
While testing NR 'expiring soon' and 'expired' letters, I noticed that the letters still show up as approved a day after expiry
The text was updated successfully, but these errors were encountered: