Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names: change NR-only entity types to modernized corp types #18241

Open
severinbeauvais opened this issue Oct 19, 2023 · 3 comments
Open

Names: change NR-only entity types to modernized corp types #18241

severinbeauvais opened this issue Oct 19, 2023 · 3 comments
Labels
enhancement New feature or request Name Request Names Team Name Request Name Examination Team NameX NameX and related services proxied via namex Priority3

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Oct 19, 2023

Names uses some NR-only entity types, such as "CR", "DBA", "FR", "RLC", etc. See this list.

This causes mapping issues between Names and LEAR, although those might be mostly resolved now.

This also causes mapping issues within Namerequest UI itself (ie, mapping legal type from business search into NR entity type, and also feature flag values). This has caused a few P1 bugs and may still cause more as we keep working in this app.

This ticket/proposal is to get rid of the NR-only entity types and use modernized corp types only (as per link above). Then we can get of all the back-and-forth mapping and put all these issues to rest.

Ref:
https://github.com/bcgov/namerequest/blob/main/src/list-data/request-action-mapping.ts
https://github.com/bcgov/namerequest/blob/69d76979093776c168b5feb554da2f80b7450e23/src/mixins/common-mixin.ts#L60
https://github.com/bcgov/namerequest/blob/69d76979093776c168b5feb554da2f80b7450e23/src/mixins/common-mixin.ts#L95
https://github.com/bcgov/namex/blob/2846a962654d27007205122a5d0f98067ff20fbc/api/namex/services/lookup/name_request_filing_actions.py#L51
https://github.com/bcgov/lear/blob/40dae2c622f7323a4452eb61cc4bb54f03ee194d/legal-api/src/legal_api/resources/v1/nr_type_map.py#L69

@severinbeauvais severinbeauvais added enhancement New feature or request Name Request Names Team Name Request Name Examination Team NameX NameX and related services proxied via namex labels Oct 19, 2023
@severinbeauvais
Copy link
Collaborator Author

@thorwolpert @lmcclung FYI

@lmcclung
Copy link
Contributor

@severinbeauvais We're only doing absolutely essential changes on name request for now. This sounds like it can wait?

@severinbeauvais
Copy link
Collaborator Author

This can wait. It's a feature request for an issue that I wanted to raise the visibility of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Name Request Names Team Name Request Name Examination Team NameX NameX and related services proxied via namex Priority3
Projects
None yet
Development

No branches or pull requests

3 participants