Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional fields to Correction #17347

Closed
danaannab opened this issue Aug 9, 2023 · 23 comments
Closed

Add additional fields to Correction #17347

danaannab opened this issue Aug 9, 2023 · 23 comments
Assignees
Labels
Dev Tasks for developers Pay Work for Pay Team

Comments

@danaannab
Copy link
Collaborator

danaannab commented Aug 9, 2023

This is an effort to keep consistent with other Entities Correction filing.

Note for Design: to the right of IA where it says view documents. there is a down arrow which when clicked should show the option file a correction. This is the benefit model when you start you can start from anywhere. Major consideration because elements specific to SR Correction

Corrections can be done on:

COOP Name
COOP Association
Business Addresses
Registered Office Contact Information
Directors
Rules
Memorandum

Still need clarification on which version is used when a couple of corrections have been made after each other on different dates.

Design:
https://preview.uxpin.com/53053d7aeb85fb29915f7afa596429aea4f2a964#/pages/164600997

@danaannab
Copy link
Collaborator Author

danaannab commented Aug 9, 2023

GIVEN that user needs to complete a correction
WHEN the user is entering the correction filing
THEN the correction filing could be done on the fields listed above

@danaannab danaannab changed the title Incorporation Application in CSR Corrections Add additional fields to Correction Aug 9, 2023
@JohnamLane
Copy link
Collaborator

Dana, please file a coop incorporation and make a note of all the fields you need to fill in. These are the fields that should be present for all coop corrections.

@PCC199 PCC199 added Dev Tasks for developers Pay Work for Pay Team labels Aug 10, 2023
@danaannab
Copy link
Collaborator Author

Legal API should allow filings UI to correct IAs Correction & Special Resolutions.

@danaannab
Copy link
Collaborator Author

Hey team! Please add your planning poker estimate with Zenhub @TMunro7 @ochiu

@Jxio Jxio self-assigned this Aug 23, 2023
@seeker25
Copy link
Collaborator

Should be consistent with other corrections:

image

@Jxio
Copy link
Collaborator

Jxio commented Aug 24, 2023

@danaannab @ethantspitt should I add "Recognition date and time"? UX has it, but not highlighted as new requirement.

@ethantspitt
Copy link
Collaborator

I don't think it's a new field, we have that already in CSR corrections output:
Screenshot 2023-08-24 at 4 12 08 PM

@Jxio
Copy link
Collaborator

Jxio commented Aug 24, 2023

Private Zenhub Image
-^ It's not on UI before, but it doesn't need correction on UX though, I can just leave what we have for now.

@ethantspitt
Copy link
Collaborator

@Jxio Gotcha, I added that field just to match with Entity's corrections (as non-editable). Let's have a chat with Dana to see if it should be added as new requirement.

@seeker25
Copy link
Collaborator

@ethantspitt @danaannab @JohnamLane we should regroom this ticket I believe with new estimates?

@JohnamLane
Copy link
Collaborator

Hey team! Please add your planning poker estimate with Zenhub @rodrigo-barraza @seeker25

@JohnamLane
Copy link
Collaborator

Please add your planning poker estimate with Zenhub @ochiu

@JohnamLane
Copy link
Collaborator

Please add your planning poker estimate with Zenhub @TMunro7

@seeker25
Copy link
Collaborator

This ticket isn't ready for QA, it needs directors figured out first and implemented.. so we can move off of using the change of address and change of directors as separate filings. It should be done generically in one filing like corps.

from Mihai:
"
Whereas changes to directors and addresses can only be done as local filings, from Filings UI, we allow these two elements to be corrected as part of the big correction framework.
"

@JohnamLane
Copy link
Collaborator

JohnamLane commented Sep 26, 2023

@ethantspitt @danaannab Blocked by director requirement and output questions that are currently with the business.

@danaannab
Copy link
Collaborator Author

GIVEN that the COOP has filed a Director Change on a present date
WHEN a new filing with a past date is needed
THEN the system should allow out of chronological date filing

@danaannab
Copy link
Collaborator Author

Note: the business would like to be able to make a correction on director details and date without being blocked / similar to Societies online

@ethantspitt
Copy link
Collaborator

Design link updated for generic Entity director correction cc @danaannab @seeker25

@seeker25
Copy link
Collaborator

@ethantspitt could you take a peak at this on DEV? It might be fairly rough, we had two people working on this ticket

@ethantspitt
Copy link
Collaborator

Checked UX for registered office and director correction, works as Entity correction, ready for QA

@seeker25
Copy link
Collaborator

I noticed an issue with Directors, if you delete all directors then add directors through the correction - it shows up in the document but doesn't show up in the directors list.

@seeker25
Copy link
Collaborator

@AshnaMehta could you try this in DEV? we know there is one limitation above -^

@seeker25
Copy link
Collaborator

I've created a PR for the fix -^

@PCC199 PCC199 closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Tasks for developers Pay Work for Pay Team
Projects
None yet
Development

No branches or pull requests

6 participants