From 8879b8896d4cbb563d0750f618c65a4e6e4666fb Mon Sep 17 00:00:00 2001 From: James Date: Wed, 6 Dec 2023 13:21:49 -0800 Subject: [PATCH 1/8] PR (TODO fix unit tests) --- package-lock.json | 4 +-- package.json | 2 +- src/components/common/HelpText.vue | 26 +++++++++++++++++++ src/components/common/NameRequestInfo.vue | 24 ++++++++++++----- src/views/AmalgamationRegular/Information.vue | 4 ++- 5 files changed, 49 insertions(+), 11 deletions(-) create mode 100644 src/components/common/HelpText.vue diff --git a/package-lock.json b/package-lock.json index 5d95d7b8d..420d9f5a6 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "business-create-ui", - "version": "5.6.7", + "version": "5.6.8", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "business-create-ui", - "version": "5.6.7", + "version": "5.6.8", "dependencies": { "@babel/compat-data": "^7.21.5", "@bcrs-shared-components/approval-type": "1.0.19", diff --git a/package.json b/package.json index 44100f14b..69a563e3d 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "business-create-ui", - "version": "5.6.7", + "version": "5.6.8", "private": true, "appName": "Create UI", "sbcName": "SBC Common Components", diff --git a/src/components/common/HelpText.vue b/src/components/common/HelpText.vue new file mode 100644 index 000000000..e51bab933 --- /dev/null +++ b/src/components/common/HelpText.vue @@ -0,0 +1,26 @@ + + + diff --git a/src/components/common/NameRequestInfo.vue b/src/components/common/NameRequestInfo.vue index 0abcb0eee..4fe9b0f8b 100644 --- a/src/components/common/NameRequestInfo.vue +++ b/src/components/common/NameRequestInfo.vue @@ -110,7 +110,7 @@ sm="3" class="pr-4" > - + [Incorporation Number] B.C. LTD. -
  • - Entity Type: {{ getEntityTypeDescription }} -
  • -
  • - Request Type: {{ requestType }} -
  • You will be filing this Incorporation Application for a company created by adding "B.C. LTD." after the Incorporation Number. @@ -140,6 +134,22 @@
  • + + + + + + diff --git a/src/views/AmalgamationRegular/Information.vue b/src/views/AmalgamationRegular/Information.vue index d10e25208..50a6f4d12 100644 --- a/src/views/AmalgamationRegular/Information.vue +++ b/src/views/AmalgamationRegular/Information.vue @@ -27,7 +27,7 @@ helpLabel="Help with Business Type" > @@ -50,6 +50,7 @@ import { DefineCompanyIF } from '@/interfaces' import { CommonMixin } from '@/mixins' import { RouteNames } from '@/enums' import { ExpandableHelp } from '@bcrs-shared-components/expandable-help' +import HelpText from '@/components/common/HelpText.vue' import NameRequestInfo from '@/components/common/NameRequestInfo.vue' import NameTranslations from '@/components/common/NameTranslations.vue' import AmalgamatingBusinesses from '@/components/Amalgamation/AmalgamatingBusinesses.vue' @@ -58,6 +59,7 @@ import AmalgamatingBusinesses from '@/components/Amalgamation/AmalgamatingBusine components: { AmalgamatingBusinesses, ExpandableHelp, + HelpText, NameRequestInfo, NameTranslations } From e8936d34b77c9ec29a612b91681767e921fc3dca Mon Sep 17 00:00:00 2001 From: James Date: Wed, 6 Dec 2023 13:44:52 -0800 Subject: [PATCH 2/8] Added unit tests for numbered am --- src/components/common/NameRequestInfo.vue | 6 ++++-- tests/unit/NameRequestInfo.spec.ts | 16 ++++++++++------ 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/src/components/common/NameRequestInfo.vue b/src/components/common/NameRequestInfo.vue index 4fe9b0f8b..a5c246838 100644 --- a/src/components/common/NameRequestInfo.vue +++ b/src/components/common/NameRequestInfo.vue @@ -146,8 +146,10 @@ sm="9" class="mt-4" > -