Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offers and proofs on wrong side of chat #2212

Open
jleach opened this issue Oct 10, 2024 · 4 comments
Open

Offers and proofs on wrong side of chat #2212

jleach opened this issue Oct 10, 2024 · 4 comments
Assignees
Labels
bug Something isn't working need-ux-wireframe

Comments

@jleach
Copy link
Member

jleach commented Oct 10, 2024

In the chat window, messages you receive (like credential offers and proof requests) will appear on the left side. Messages you send from your BC Wallet will appear on the right side. This helps you easily see who sent which message. Right now offers and proof messages appear on the wrong side.

Image

@jleach jleach added the bug Something isn't working label Oct 15, 2024
@jeznorth
Copy link

@knguyenBC can you verify the UI is behaving as expected.

@knguyenBC
Copy link

knguyenBC commented Oct 16, 2024

I reviewed old designs and how it's implemented now is NOT the intention.

The intention was to have whoever sent the message for the message to be displayed on their side. So proof requests and credentials offers should be displayed from their side. As shown here.

image

The message should state "[Connection name] is requesting for information" or "[Connection name] is offering you a new credential"

@cvarjao
Copy link
Member

cvarjao commented Oct 22, 2024

@knguyenBC,

  • received proof request shows on "their" side, but once that proof request is accepted/declined, does it switch to "my" side?
  • sent proof request (from mobile verifier) shows on "my" side. once there is a response, does it switch to "their" side?

@knguyenBC
Copy link

knguyenBC commented Oct 22, 2024

Please switch the chat bubble to the holder. Here's some ACs for clarity.

Given a proof request was sent over a connection
When the holder shares information
Then the chat bubble will switch to the holder side with the content updating to "you shared information"
and the button will update to view

Given a proof request was sent over a connection
When the holder declines to share information
Then the chat bubble will switch to the holder side with the content updating to "you rejected a proof request"
and the button is removed

Given a credential offer was sent over a connection
When the holder accepts the offer
Then the chat bubble will switch to the holder side with the content updating to "you received a credential"
and the button will update to view

Given a proof request was sent over a connection
When the holder declines the offer
Then the chat bubble will switch to the holder side with the content updating to "you declined a credential offer"
and the button is removed

Example:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need-ux-wireframe
Projects
None yet
Development

No branches or pull requests

4 participants