Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-2036: Map Filter - ERP Projects #2733

Merged
merged 3 commits into from
Oct 22, 2024
Merged

PIMS-2036: Map Filter - ERP Projects #2733

merged 3 commits into from
Oct 22, 2024

Conversation

LawrenceLau2020
Copy link
Collaborator

🎯 Summary

PIMS-2036

Changes

  • Added a new ToggleSwitch on the map page to display properties that are in ERP projects.

Testing

  • To test the filter, when selected it should only display properties that are in ERP.
  • You can also test adding additional filters when this is selected as well, eg. Land or Building, Agency, etc.
  • You will probably need to double check the number of properties in each project that is in "Approved for ERP" status just to make sure the results match.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 2733. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented Oct 22, 2024

Code Climate has analyzed commit 9cf53f4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.4%.

View more on Code Climate.

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toggle works well and filters map as expected (both as admin and general user) as well as working well with other filter options (even the polygon drawing!)

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well too.

@LawrenceLau2020 LawrenceLau2020 merged commit 62411d0 into main Oct 22, 2024
12 checks passed
@LawrenceLau2020 LawrenceLau2020 deleted the PIMS-2036 branch October 22, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants