Consolidate Graphic Elements to One Class #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtking2
reviewed
Oct 15, 2019
|
Sweet. This is much cleaner 👌 Should close #30 now since everything is covered in this. |
mtking2
reviewed
Oct 15, 2019
mtking2
reviewed
Oct 15, 2019
LagTag
commented
Oct 15, 2019
lib/zebra/zpl/graphic.rb
Outdated
| @graphic_type = type | ||
| end | ||
|
|
||
| def self.valid_graphic_type?(type) |
There was a problem hiding this comment.
Guess I forgot to remove this method when I created the setter for graphic type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ellipse, Box, Circle, Symbol, and Diagonal elements all added to one class.
Added Spec for new graphic class. Deleted Diagonal and elipse classes (since these were only added a few weeks ago, I didn't deprecate them.
Deprecated warning for Box class as it is now redundant. Eventually will delete this class.
Closes #30