Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specs + minor maintenance #39

Merged
merged 19 commits into from
Oct 15, 2019
Merged

Fix specs + minor maintenance #39

merged 19 commits into from
Oct 15, 2019

Conversation

mtking2
Copy link
Collaborator

@mtking2 mtking2 commented Oct 14, 2019

This PR will get the existing tests back up to par and passing. Addresses and closes #35

Tests to update

  • PrintJob spec
  • Barcode spec
  • Box spec
  • CharacterSet spec
  • Label spec
  • PDF417 spec
  • Qrcode spec
  • Text spec

Removals

  • An un-needed and unused label attribute called print_density
  • The dependency on the cups gem. The cups gem is no longer being used so we best remove it.
  • The unused v_multiplier and h_multiplier attributes on the Text module and the specs that go along with them. There are also unused modules: BaseMultiplier, HorizontalMultiplier, and VerticalMultiplier that could also be removed.

@mtking2 mtking2 added the wip Work In Progress label Oct 14, 2019
@mtking2 mtking2 removed the wip Work In Progress label Oct 15, 2019
@mtking2 mtking2 requested a review from LagTag October 15, 2019 20:05
@mtking2
Copy link
Collaborator Author

mtking2 commented Oct 15, 2019

image
😎 😎

@mtking2 mtking2 merged commit cab8f23 into bbulpett:master Oct 15, 2019
@mtking2 mtking2 added this to the Version 1.1.0 milestone Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specs failing?
1 participant