Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add useQueueUrlAsEndpoint to ConsumerOptions #472

Conversation

mogu4iy
Copy link
Contributor

@mogu4iy mogu4iy commented Mar 12, 2024

Resolves #NUMBER

Description:

Add useQueueUrlAsEndpoint support in Consumer initialization

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Why is this change required?:

Let use QueueUrl hostname as the endpoint with @aws-sdk/client-sqs@^v3.507.0

Code changes:

Add useQueueUrlAsEndpoint to ComsumerOptions, so it can be passed to SQSClient.
Add useQueueUrlAsEndpoint check in Consumer constructor to pass true as default value.


Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mogu4iy mogu4iy requested review from a team as code owners March 12, 2024 08:03
Copy link

github-actions bot commented Mar 12, 2024

CLA Assistant Lite bot CLA CHECK All Contributors have signed the CLA

@mogu4iy
Copy link
Contributor Author

mogu4iy commented Mar 12, 2024

I have read the CLA Document and I hereby sign the CLA

@mogu4iy
Copy link
Contributor Author

mogu4iy commented Mar 12, 2024

@nicholasgriffintn I'd be happy if you check it ;)

Copy link

codeclimate bot commented Mar 12, 2024

Code Climate has analyzed commit 9a4db49 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.3% (0.0% change).

View more on Code Climate.

Copy link
Member

@nicholasgriffintn nicholasgriffintn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, previously verified on sqs-producer that true was the default for this.

@nicholasgriffintn nicholasgriffintn merged commit 075bd54 into bbc:main Mar 12, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants