-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support non-standard errors #414
Conversation
Code Climate has analyzed commit ab1c57f and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 98.2% (0.1% change). View more on Code Climate. |
Would love to see this land in the library! I just ran into this today and left a comment over here about how I had to work around it. |
Sorry, this PR seems to have not been updated, as said previously, the tests appear to be passing but I would prefer the tests to be a little better, in particular, it's probably worth while adding E2E tests in for an implementation similar. That said, this is probably fine as long as it actually solves the issue, I don't truly know as we don't have an example application for this issue. |
Thank you! |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Resolves #411
Support non-standard errors. Errors with a read only "message" raise - "Cannot set property message of X which has only a getter"
Description:
Allows the library to handle errors that have been thrown in non standard ways.
Type of change:
Why is this change required?:
Allows users to implement custom error handling solutions.
Code changes:
toStandardError
andtoTimeoutError