Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade or remove p-event #330

Closed
nicholasgriffintn opened this issue Dec 9, 2022 · 2 comments
Closed

Upgrade or remove p-event #330

nicholasgriffintn opened this issue Dec 9, 2022 · 2 comments
Labels
bug

Comments

@nicholasgriffintn
Copy link
Member

p-event breaks the Mocha tests when upgraded, this ticket is to look into why, if we can upgrade it, do that otherwise remove p-event from the tests.
@nicholasgriffintn nicholasgriffintn mentioned this issue Dec 9, 2022
Merged
9 tasks
@nicholasgriffintn nicholasgriffintn modified the milestones: 5.4.0, TBD Dec 9, 2022
@nicholasgriffintn
Copy link
Member Author

Looks like p-event is now ESM only, so it would require that we also move to ESM, which I'm not sure if we want to do, looking at it 4.2.0 works just fine for our tests though, so this might not be a huge deal.

@nicholasgriffintn
Copy link
Member Author

I think this works fine for now

@nicholasgriffintn nicholasgriffintn removed this from the TBD milestone Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicholasgriffintn