Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncaught:exception event causing E2E failures on STY and MAPs #9465

Closed
LilyL0u opened this issue Sep 29, 2021 · 1 comment · Fixed by #9521
Closed

uncaught:exception event causing E2E failures on STY and MAPs #9465

LilyL0u opened this issue Sep 29, 2021 · 1 comment · Fixed by #9521
Assignees
Labels
bug Something isn't working cross-team For visibility for both World Service teams (Engage & Media) cypress Cypress changes are required

Comments

@LilyL0u
Copy link
Contributor

LilyL0u commented Sep 29, 2021

The E2Es are now failing due to uncaught exceptions, since 14:55 on Tuesday 28th September. The error is

'TypeError: The following error originated from your application code, not from Cypress. It was caused by an unhandled promise rejection.'

I cannot replicate this running the tests on my computer. I cannot see any console errors.

It is likely to be related to the PR removing the code in this change https://github.com/bbc/simorgh/pull/9457/files

Do we want to put the code back to handle the exception, or fix the source of the exception?

Here are some screenshots of the slightly different error messages on different pages:

simorgh-cd, TestEnvironment, MAP
Screenshot 2021-09-29 at 14 33 48

live-simorgh-e2e-scheduled, Story Page, AMP
Screenshot 2021-09-29 at 14 38 34

live-simorgh-e2e-scheduled, MAP

Screenshot 2021-09-29 at 14 41 36

test-simorgh-e2e-scheduled, MAP

Screenshot 2021-09-29 at 14 45 00

I have included some of the test failures after the exception test failure as it shows that whatever is happening is also affecting the check for iframes etc

@LilyL0u LilyL0u added bug Something isn't working cross-team For visibility for both World Service teams (Engage & Media) cypress Cypress changes are required labels Sep 29, 2021
@LilyL0u LilyL0u changed the title uncaught:exception event causing E2E failures on multiple page types uncaught:exception event causing E2E failures on STY and MAPs Sep 29, 2021
@amoore108
Copy link
Contributor

Could be related to changes here #9457 that removed code to ignore promise based exceptions. Re-adding this will probably fix the issue, although its worth exploring why those errors are being thrown in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cross-team For visibility for both World Service teams (Engage & Media) cypress Cypress changes are required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants