Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination - Recommended markup uses separator ARIA role in invalid location #186

Open
JoshTumath opened this issue Oct 18, 2024 · 1 comment

Comments

@JoshTumath
Copy link
Contributor

The GEL Technical Docs recommend the following markup for the pagination:

https://bbc.github.io/gel/components/load-more/#the-pagination-component

  <ol class="gel-pages-numbered">
    <li><a href="?page=1" aria-current="page">1</a></li>
    <li><a href="?page=2">2</a></li>
    <li><a href="?page=3">3</a></li>
    <li><a href="?page=4">4</a></li>
    <li><a href="?page=5">5</a></li>
    <li><a href="?page=6">6</a></li>
    <li><a href="?page=7">7</a></li>
    <li role="separator">&hellip;</li>
    <li><a href="?page=999">999</a></li>
  </ol>

It says the list item in the pagination with the ellipsis ('...') needs to be in a separator role, but changing a list item role to a separator is not allowed, so it gets flagged as invalid markup in tools like the axe automated a11y tests.

Can we change the technical docs to stop recommending that? And what would be an appropriate alternative?

@JoshTumath
Copy link
Contributor Author

I've created a PR in the WebCore Design System to just rely on the ellipsis character to convey the information we want to screen reader users. https://github.com/bbc/web/pull/17618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant