[Fix #4402] Add Cop.autocorrect_incompatible_with

[backus]

With this change, cops can now specify which cops their autocorrect
functionality is incompatible with. This makes it easier for third
party cops to specify cops they are not compatible with and have that
incompatibility be respected during correction. Autocorrect mapping
is not resolved on boot so this should play well with third party
extensions like rubocop-rspec.

---

Before submitting the PR make sure the following are checked:

• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Used the same coding conventions as the rest of the project.
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
• All tests are passing.
• The new code doesn't generate RuboCop offenses.
• The PR relates to only one subject with a clear title
  and description in grammatically correct, complete sentences.
• Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

[bbatsov]

I wonder if something else couldn't be added about the cop renamings. Right now that mapping is hardcoded as well in a hash and it's not exactly easy to find.

[backus]

That would be great. Same with config options I think? I had to do something hacky for rubocop-rspec I believe when I renamed some configuration

[Drenmi]

I think this is so much better in terms of discoverability. 🙂

[backus]

I wonder if something else couldn't be added about the cop renamings. Right now that mapping is hardcoded as well in a hash and it's not exactly easy to find.

@bbatsov I agree but just to be clear you're not saying that should come in this PR, right?

[bbatsov]

@bbatsov I agree but just to be clear you're not saying that should come in this PR, right?

Sure. Just remembered I dislike the code we use to track renamings. It's not exactly the same, though - the current code also tracks removed cops. But it will still be an improvement to separate the concerns there.