Fix Rails/FilePath join argument misdetection #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutaro
force-pushed
the
file_path_false_positive
branch
from
e93badc
to
02a99b0
Compare
|
Btw, there's also #4178 This seems to be targeting the same problem. |
|
I don't think its the same. This is not about |
bbatsov
reviewed
Apr 1, 2017
| @@ -56,4 +56,13 @@ | |||
| expect(cop.offenses.size).to eq(1) | |||
| end | |||
| end | |||
|
|
|||
| context 'Rails.root.join used with / operator' do | |||
There was a problem hiding this comment.
The description here is not clear enough. Obviously this pertains to having used / in the context of interpolation.
There was a problem hiding this comment.
@bbatsov Revised the description and example. How about this?
soutaro
force-pushed
the
file_path_false_positive
branch
from
02a99b0
to
e89e942
Compare
Ignore if the argument is not a string.
soutaro
force-pushed
the
file_path_false_positive
branch
from
e89e942
to
c31ac08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails/FilePathcop tests ifjoinarguments contain'/'only using theirsource. It may cause a misdetection if its argument contains/operator of Ruby. This PR implements more strict test by checking if the node is a:str.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).