Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a regression in UselessAssignment with a single top level conditional #4160

Merged

Conversation

yujinakayama
Copy link
Collaborator

@yujinakayama yujinakayama commented Mar 24, 2017

This fixes a regression where UselessAssignment cop may not properly detect useless assignments when there's only a single conditional expression in the top level scope:

if flag
  foo = 1 # This is useless ...
else
  puts foo # ... since this will never run together with the assignment
end

This regression was introduced in 8eecfe0.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@yujinakayama yujinakayama force-pushed the fix-regression-in-useless-assignment branch from 2b10175 to d140ccc Compare March 24, 2017 10:01
@bbatsov bbatsov merged commit 8da64a9 into rubocop:master Mar 24, 2017
@bbatsov
Copy link
Collaborator

bbatsov commented Mar 24, 2017

The Jedi have returned! :-) Happy to see you back, @yujinakayama!

@yujinakayama yujinakayama deleted the fix-regression-in-useless-assignment branch March 24, 2017 17:00
@yujinakayama
Copy link
Collaborator Author

I'm also happy 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants