Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [#3989] Follow redirects for RemoteConfig #4013

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Fix [#3989] Follow redirects for RemoteConfig #4013

merged 1 commit into from
Feb 10, 2017

Conversation

buenaventure
Copy link
Contributor

@buenaventure buenaventure commented Feb 3, 2017

Makes RemoteConfig#request follow redirects with a limit of 10.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@bbatsov
Copy link
Collaborator

bbatsov commented Feb 4, 2017

I guess you didn't run RuboCop on your changes. :-)

@buenaventure
Copy link
Contributor Author

buenaventure commented Feb 4, 2017 via email

@bbatsov
Copy link
Collaborator

bbatsov commented Feb 5, 2017

One more thing - this needs a changelog entry.

@bbatsov bbatsov merged commit 573cf0d into rubocop:master Feb 10, 2017
@volmer
Copy link
Contributor

volmer commented Mar 27, 2017

Are there any tests covering this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants