Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #3839] Detect hash literal for String#% #3872

Merged
merged 1 commit into from
Jan 7, 2017
Merged

[Fix #3839] Detect hash literal for String#% #3872

merged 1 commit into from
Jan 7, 2017

Conversation

backus
Copy link
Contributor

@backus backus commented Jan 7, 2017 •
edited
Loading

Fixes #3839. See the issue for more context

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@bbatsov bbatsov merged commit 4feadc9 into rubocop:master Jan 7, 2017
@backus backus deleted the fix/format-string-hash branch January 7, 2017 08:13
@backus backus mentioned this pull request Jan 7, 2017
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@backus @bbatsov