Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lint/MultipleCompare cop #3795

Merged
merged 1 commit into from
Dec 18, 2016
Merged

Conversation

pocke
Copy link
Collaborator

@pocke pocke commented Dec 18, 2016

In Ruby, the following code raises an error.

x = 20
0 < x < 100 # => NoMethodError: undefined method `<' for true:TrueClass

The error is confusing for beginner and Python programmer.

This cop suggests and autocorrects the following code instead.

x = 20
0 < x && x < 100

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

In Ruby, the following code raises an error.

```ruby
x = 20
0 < x < 100 # => NoMethodError: undefined method `<' for true:TrueClass
```

The error is confusing for beginner and Python programmer.

This cop suggests and autocorrects the following code instead.

```ruby
x = 20
0 < x && x < 100
```
@bbatsov bbatsov merged commit 164a488 into rubocop:master Dec 18, 2016
@bbatsov
Copy link
Collaborator

bbatsov commented Dec 18, 2016

👍

@pocke pocke deleted the new-cop-Lint/CompareChain branch December 18, 2016 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants