Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #3780] Maintain parentheses in auto-correcting Rails/HttpPositionalArguments #3783

Merged
merged 1 commit into from
Dec 12, 2016
Merged

[Fix #3780] Maintain parentheses in auto-correcting Rails/HttpPositionalArguments #3783

merged 1 commit into from
Dec 12, 2016

Conversation

kevindew
Copy link
Contributor

@kevindew kevindew commented Dec 11, 2016 •
edited
Loading

Fix for: #3780

During the autocorrect process for Rails/HttpPositionalArguments
this checks whether the original node had parentheses. If there are
parentheses these are included in the formatting of the autocorrected
method.

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@kevindew kevindew changed the title [Fix #3780] Maintain parentheses in auto-correcting Rails HTTP positional arguments [Fix #3780] Maintain parentheses in auto-correcting Rails/HTTP positional arguments Dec 11, 2016
@kevindew kevindew changed the title [Fix #3780] Maintain parentheses in auto-correcting Rails/HTTP positional arguments [Fix #3780] Maintain parentheses in auto-correcting Rails/HttpPositionalArguments Dec 11, 2016
@kevindew kevindew force-pushed the parentheses-in-rails-http-positional-arguments branch from f8d89ec to 0319adc Compare December 11, 2016 16:06
@kevindew
Maintain parentheses in Rails/HttpPositionalArguments
0d05590 
Fix for: rubocop#3780

During the autocorrect process for `Rails/HttpPositionalArguments`
this checks whether the original node had parentheses. If there are
parentheses these are included in the formatting of the autocorrected
method.
@kevindew kevindew force-pushed the parentheses-in-rails-http-positional-arguments branch from 0319adc to 0d05590 Compare December 11, 2016 16:21
@bbatsov bbatsov merged commit 356860e into rubocop:master Dec 12, 2016
@bbatsov
Copy link
Collaborator

bbatsov commented Dec 12, 2016

👍

@tejasbubane tejasbubane mentioned this pull request Dec 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevindew @bbatsov