Make Style/RedundantSelf accept self.() #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iGEL
force-pushed
the
not-redundant-self
branch
2 times, most recently
from
31e6f99
to
93c6172
Compare
|
Can someone help me with this failure? It seems unrelated and I can't reproduce it locally with this Dockerfile: FROM ruby:2.1.10
WORKDIR /code
ADD . /code/
RUN bundle install
CMD bundle exec rake |
bbatsov
reviewed
Sep 30, 2016
| @@ -123,7 +123,8 @@ def regular_method_call?(node) | |||
| !(operator?(method_name) || | |||
| keyword?(method_name) || | |||
| constant_name?(method_name) || | |||
| node.asgn_method_call?) | |||
| node.asgn_method_call? || | |||
| method_name == :call) | |||
There was a problem hiding this comment.
What's not good enough - it will match both self.() and self.call.
bbatsov
reviewed
Sep 30, 2016
| @@ -187,6 +187,12 @@ | |||
| expect(cop.offenses).to be_empty | |||
| end | |||
|
|
|||
| it 'accepts a self receiver of .()' do | |||
There was a problem hiding this comment.
You should also have a test that this doesn't accept self.call.
|
Seems the failure was random. |
|
@iGEL ping :-) |
|
@iGEL Ping 2 :-) |
iGEL
force-pushed
the
not-redundant-self
branch
from
93c6172
to
a3f8428
Compare
iGEL
force-pushed
the
not-redundant-self
branch
from
a3f8428
to
9b6b87f
Compare
|
@bbatsov Pong :-) Hope it's fine now, I don't have much experience working with the AST or developing for Rubocop. |
bbatsov
reviewed
Oct 20, 2016
| @@ -143,6 +144,10 @@ def constant_name?(method_name) | |||
| method_name.match(/^[A-Z]/) | |||
| end | |||
|
|
|||
| def braces_style_call?(node) | |||
| node.source.start_with?('self.(') | |||
There was a problem hiding this comment.
node.loc.selector.nil? is a way more efficient way to check for this.
To send `.()` (an alternative to `.call`) to `self`, you have to explicitly call `self`. However `Style/RedundantSelf` cop was registering an offence for `self.()`.
iGEL
force-pushed
the
not-redundant-self
branch
from
9b6b87f
to
980b2ee
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To send
.()(an alternative to.call) toself, you have to explicitly callself. HoweverStyle/RedundantSelfcop was registering an offence forself.(). Probably is also allowsself.call, but I hope we can live with that.