TargetRubyVersion takes precedence over .ruby-version #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
| TargetRubyVersion: 2.0 | ||
| # If a value is specified for TargetRubyVersion then it is used. | ||
| # Else if .ruby-version exists and it contains an MRI version it is used. | ||
| # Otherwise the default (2.0) ruby is used. |
There was a problem hiding this comment.
Perhaps clarify that these are MRI version numbers.
There was a problem hiding this comment.
Add to the start of the comment on line 76.
There was a problem hiding this comment.
I don't like the final sentence - it should be something like Otherwise we fallback to the oldest officially supported Ruby version (2.0).
|
👍 besides that one last comment. |
|
This looks great! |
| end | ||
| end | ||
|
|
||
| context 'when TargetRubyVersion is unset' do |
|
@bbatsov Thanks for the feedback. I've pushed changes to address all of it. |
Closed
Neodelf
pushed a commit
to Neodelf/rubocop
that referenced
this pull request
Oct 15, 2016
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion on #3251 regarding JRuby and other values that can appear in .ruby-version, I made this change to see if it can help to resolve the situation.
In order to change the precedence, I had to move the default for
TargetRubyVersionfromdefault.ymlto code.[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.