Make cop names more flexible in CommentConfig lines #3250
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3201 introduced support for arbitrary comments after cop names.
However, the previous regexp for cop names was roughly
[\w/]+
. The new regexp for a cop name is([A-Z][a-z]+/)?(?:[A-Z][a-z]+)+
.This regexp is too restrictive for some existing custom cops. All of the cops in rubocop-rspec are in a
RSpec
department that does not match this regexp.This change makes the cop name regexp
([A-Z]\w+/)?(?:[A-Z]\w+)
to allow better back compatibility with existing custom cops.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).and description in grammatically correct, complete sentences.