Add autocorrect to Style/EachForSimpleLoop cop
#3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejasbubane
force-pushed
the
autocorrect-each-for-simple-loop
branch
from
9a8cede
to
ed02663
Compare
| end | ||
| end | ||
|
|
||
| def_node_matcher :bad_each_loop, <<-PATTERN |
There was a problem hiding this comment.
These 2 "node matcher" methods can be combined. The fact that one of them returns an integer doesn't stop it from also being used as a predicate.
|
Wow, I just introduced this cop a couple of days ago and already it has autocorrect! Awesome! Thanks @tejasbubane! |
tejasbubane
force-pushed
the
autocorrect-each-for-simple-loop
branch
from
ed02663
to
2fa34d8
Compare
Neodelf
pushed a commit
to Neodelf/rubocop
that referenced
this pull request
Oct 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @alexdowad
Before submitting the PR make sure the following are checked:
master(if not - rebase it)and description in grammatically correct, complete sentences.