Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnusedBlockArgument's IgnoreEmptyBlocks parameter from being ignored #3192

Merged
merged 1 commit into from
Jun 3, 2016
Merged

Fix UnusedBlockArgument's IgnoreEmptyBlocks parameter from being ignored #3192

merged 1 commit into from
Jun 3, 2016

Conversation

jfelchner
Copy link
Contributor

@jfelchner jfelchner commented Jun 3, 2016

In 8f01fbe a very old patch was applied to a new tree. Because of this, the
changes made in that commit to the default config actually added the same key
for the Lint/UnusedBlockArgument cop a second time. Because of how YAML
parses, the previous definition, which defined the IgnoreEmptyBlocks
parameter was lost and because of that, any configuration that defined it
would now throw a warning.

Also brought up in #3095


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it)
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.

In 8f01fbe a very old patch was applied to a new tree.  Because of this, the
changes made in that commit to the default config actually added the same key
for the `Lint/UnusedBlockArgument` cop a second time.  Because of how YAML
parses, the previous definition, which defined the `IgnoreEmptyBlocks`
parameter was lost and because of _that_, any configuration that defined it
would now throw a warning.

Also brought up in #3095
@bbatsov bbatsov merged commit c8ae847 into rubocop:master Jun 3, 2016
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 3, 2016

👍

Neodelf pushed a commit to Neodelf/rubocop that referenced this pull request Oct 15, 2016
…red (rubocop#3192)

In 8f01fbe a very old patch was applied to a new tree.  Because of this, the
changes made in that commit to the default config actually added the same key
for the `Lint/UnusedBlockArgument` cop a second time.  Because of how YAML
parses, the previous definition, which defined the `IgnoreEmptyBlocks`
parameter was lost and because of _that_, any configuration that defined it
would now throw a warning.

Also brought up in rubocop#3095
@jfelchner jfelchner deleted the fixed/incorrectly-applied-patch-to-default-config branch March 18, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants