Make Style/ModuleFunction configurable with different styles #3173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ' module_function', | ||
| ' def test; end', | ||
| 'end']) | ||
| expect(cop.messages).to eq([described_class::EXTEND_SELF_MSG]) |
There was a problem hiding this comment.
You checked the highlights for the other config, but not here.
|
Apart from my small remark - you should squash your commits together. |
The two supported styles are: module_function and extend_self. Offenses are not auto-corrected since the two styles have slightly different semantics. The default style still recommends `module_function` instead of `extend self`.
|
Added highlight check and squashed. Thanks! |
|
👍 |
Neodelf
pushed a commit
to Neodelf/rubocop
that referenced
this pull request
Oct 15, 2016
…#3173) The two supported styles are: module_function and extend_self. Offenses are not auto-corrected since the two styles have slightly different semantics. The default style still recommends `module_function` instead of `extend self`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two supported styles are:
module_functionandextend_self.Offenses are not auto-corrected since the two styles have
slightly different semantics.
The default style still recommends
module_functioninsteadof
extend self.Before submitting the PR make sure the following are checked:
master(if not - rebase it)and description in grammatically correct, complete sentences.