Allow Style/Encoding to enforce using no encoding comment #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodysNightmare
force-pushed
the
encoding_never
branch
from
421ed71
to
0085231
Compare
| @@ -425,10 +425,11 @@ Style/EmptyLinesAroundModuleBody: | |||
| # AutoCorrectEncodingComment must match the regex | |||
| # /#.*coding\s?[:=]\s?(?:UTF|utf)-8/ | |||
| Style/Encoding: | |||
| EnforcedStyle: always | |||
| EnforcedStyle: never | |||
There was a problem hiding this comment.
Since this cop is disabled by default, I assume that the default is that we live in a"post 1.9" world.
Therefore I thought never would be the more apropriate default.
However, this will cause offenses on existing configurations, when you just enabled this cop, without specifying an enforced style, e.g.:
Style/Encoding:
Enabled: true
There was a problem hiding this comment.
True. We can re-enable it once we drop support for 1.9.
Usable for applications that moved from <= 1.9 to >= 2.0, since autocorrection can now remove those comments again.
NobodysNightmare
force-pushed
the
encoding_never
branch
from
0085231
to
0508b26
Compare
Neodelf
pushed a commit
to Neodelf/rubocop
that referenced
this pull request
Oct 15, 2016
Usable for applications that moved from <= 1.9 to >= 2.0, since autocorrection can now remove those comments again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whats in
You can now configure rubocop to enforce having no encoding comments:
This means even if there are non-ASCII characters in a file, rubocop will offend on an
# encoding: utf-8comment.I deem this useful for applications that are running on a recent ruby version and therefore do not need the comment anymore. Since many applications used to be running on 1.9, they may still contain those comments, even if they are unneccessary.