Fix incorrect auto-correct of === in ConditionalAssignment #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrosenblum
force-pushed
the
conditional_assignment_bug
branch
from
98db8b1
to
16bf62d
Compare
| @@ -82,7 +82,7 @@ def lhs_for_send(node) | |||
| indices = node.children[2...-1].map(&:source).join(', ') | |||
| "#{receiver}[#{indices}] = " | |||
| elsif node.method_name.to_s.end_with?(EQUAL) && | |||
| ![:!=, :==].include?(node.method_name) | |||
| ![:!=, :==, :===].include?(node.method_name) | |||
There was a problem hiding this comment.
You should also check for >=.
There was a problem hiding this comment.
Good catch. >= and <= had the same bug. I also added tests for every weird math assignment operator out there that I could find.
rrosenblum
force-pushed
the
conditional_assignment_bug
branch
from
16bf62d
to
ec062d1
Compare
bbatsov
added a commit
that referenced
this pull request
Mar 22, 2016
Fix incorrect auto-correct of === in ConditionalAssignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on adding support for more operators to
ConditionalAssignmentand coming up with a new name for it, when I came across a bug. I can't imagine that the bug would happen often, but it seemed worth while to get a fix in.