New Cop Style/MultilineMethodDefinitionBraceLayout #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panthomakos
force-pushed
the
multiline-method-def-brace-layout
branch
from
e2b8cb3
to
fdfe8b4
Compare
| @@ -21,22 +21,22 @@ module Style | |||
| # # bad | |||
| # { a: 'a', | |||
| # b: 'b' | |||
| # ] | |||
| # } | |||
There was a problem hiding this comment.
Corrected these while I was at it - happy to move to a separate PR as well.
Identical to `Style/MultilineArrayBraceLayout` and `Style/MultilineHashBraceLayout`, except for method definitions. Also corrected braces in the the documentation for `Style/MultilineHashBraceLayout`.
panthomakos
force-pushed
the
multiline-method-def-brace-layout
branch
from
fdfe8b4
to
18cba56
Compare
bbatsov
added a commit
that referenced
this pull request
Feb 3, 2016
…layout New Cop Style/MultilineMethodDefinitionBraceLayout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical to
Style/MultilineArrayBraceLayoutandStyle/MultilineHashBraceLayout, except for method definitions.Also corrected braces in the the documentation for
Style/MultilineHashBraceLayout.